Actually your implementation only ever adds one item, the perf is off by around 100x
-
-
Replying to @_developit @yoshuawuyts
you can see it if you step through or run with CPU throttling - here's Choo:pic.twitter.com/gEZL8xC93E
1 reply 0 retweets 1 like -
Replying to @_developit @yoshuawuyts
... and here's Preact: (notice the 100 items instead of 1)pic.twitter.com/jERtMiHait
1 reply 0 retweets 1 like -
Replying to @_developit @yoshuawuyts
Not meaning to downplay the perf gains - choo 6 is nice and fast. Just the number is off by quite a bit because the bench is broken
1 reply 0 retweets 3 likes -
Replying to @_developit @yoshuawuyts
related: this is one reason I kinda hate benchmarks
1 reply 0 retweets 2 likes -
Replying to @_developit
lol, same - yeah looks like you're right, oops - apparently it's been broken for a year then?
1 reply 0 retweets 1 like -
Replying to @yoshuawuyts
lol I've had sillier things happen to me. Seems like the input event debounce is never triggering cause the bench is ~synchronous.
1 reply 0 retweets 1 like
ahhh, yeah that would explain a bunch; given choo's emit('render') mechanism is async too I would assume fixing the bench wouldn't be easy
-
-
Replying to @yoshuawuyts
indeed - I used to have to trigger a sync rendering mode for this one. Switching async to use Promise.then() fixed it though.
0 replies 0 retweets 0 likesThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.