yosh

@aredridel what's breaking on 7. we can revert!

not sure, tapped out for the night and digging in tomorrow; from a quick glance it seemed http/net related @aredridel

keep me in the loop and I'll follow up during the week. fwiw his is kind of the point of v7 imho. catch stuff before lts

ok, think I found it. Can't pass null to listen. https://travis-ci.org/yoshuawuyts/crash-reporter-service/jobs/192032588 … | https://github.com/yoshuawuyts/crash-reporter-service/blob/master/tests/lib.js#L40 … | https://github.com/nodejs/node/blob/97f001ab167875c8e8e8418fa55ff14ef76a4064/lib/net.js#L1383 …

is this a recent failure? that change has been in 7.x the entire time. Posting in the thread where it landed

a port can be undefined or a number. Null was an accident in the method args, but not in the option object.

You've been able to omit the port for a looooong time. Can't remember when I last saw code use null

omit, yes. Use null, don't know. Undefined is still a good one.