@aredridel what's breaking on 7. we can revert!
-
-
Replying to @MylesBorins
not sure, tapped out for the night and digging in tomorrow; from a quick glance it seemed http/net related
@aredridel1 reply 0 retweets 0 likes -
Replying to @yoshuawuyts
keep me in the loop and I'll follow up during the week. fwiw his is kind of the point of v7 imho. catch stuff before lts
1 reply 0 retweets 1 like -
Replying to @MylesBorins
ok, think I found it. Can't pass null to listen. https://travis-ci.org/yoshuawuyts/crash-reporter-service/jobs/192032588 … | https://github.com/yoshuawuyts/crash-reporter-service/blob/master/tests/lib.js#L40 … | https://github.com/nodejs/node/blob/97f001ab167875c8e8e8418fa55ff14ef76a4064/lib/net.js#L1383 …
1 reply 1 retweet 1 like -
Replying to @yoshuawuyts
is this a recent failure? that change has been in 7.x the entire time. Posting in the thread where it landed
2 replies 0 retweets 0 likes -
Replying to @MylesBorins @yoshuawuyts
a port can be undefined or a number. Null was an accident in the method args, but not in the option object.
2 replies 0 retweets 0 likes -
You've been able to omit the port for a looooong time. Can't remember when I last saw code use null
2 replies 0 retweets 0 likes -
omit, yes. Use null, don't know. Undefined is still a good one.
1 reply 0 retweets 1 like -
Before omitting the the port you could use zero as the port and it would have the same effect
1 reply 0 retweets 0 likes -
Replying to @wa7son @matteocollina and
introduced in v0.5.6: https://nodejs.org/docs/v0.5.6/api/net.html#server.listen …
#archeology
1 reply 1 retweet 0 likes
lol yeah, I usually omit the port - figured there'd be no difference between null and undefined tho @matteocollina @MylesBorins
-
-
Replying to @yoshuawuyts @wa7son and
Oh, the joys of null in JS How I sing to thee But thou returneth not Yourself to me
1 reply 6 retweets 11 likes - 1 more reply
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.