Off to play video games now; but filed another PR: unsafe increment_strong_count / decrement_strong_count on Arc. This came up during review of another patch, so figured I'd just go ahead and try implementing it heh.https://github.com/rust-lang/rust/pull/70733 …
-
Show this thread
-
Third patch to rustlang: add slice::fill Pretty much wrote an essay in the issue notes, but think this is a good one.https://github.com/rust-lang/rust/pull/70752 …
1 reply 0 retweets 3 likesShow this thread -
(I have A List of things I've been meaning to PR to std but couldn't get through. Might slowly move to tick off a few of these.)
1 reply 0 retweets 1 likeShow this thread -
4. Add conversion from Arc<Fn> for Waker. This allows for quickly creating a waker from a closure for instrumentation purposes. Think it also helps reinforce the mental model of: "A waker is a thread-safe callback". Also really liking the Wake trait! https://github.com/rust-lang/rust/pull/70764 …pic.twitter.com/OtttO5FDPK
1 reply 0 retweets 5 likesShow this thread -
5. Add BufRead::read_while. This provides a non-inclusive counterpart to `BufRead::read_until` (e.g. doesn't include the last byte seen). Which is incredibly useful when you want to do some quick parsing on a stream.pic.twitter.com/o9XGNsRjTi
1 reply 0 retweets 1 likeShow this thread -
Oops, forgot the link:https://github.com/rust-lang/rust/pull/70772 …
1 reply 0 retweets 0 likesShow this thread -
6. Add core::ready! macro This is one of the pieces provided by futures-core and used in virtually every Future, Stream, AsyncRead, and AsyncWrite impl. Being only 5 lines this makes a lot of sense for the stdlib to provide. https://github.com/rust-lang/rust/pull/70817 …pic.twitter.com/XLCvyGKvB1
1 reply 0 retweets 2 likesShow this thread -
7. Found some stray comments that are no longer accurate.https://github.com/rust-lang/rust/pull/70824 …
1 reply 0 retweets 0 likesShow this thread -
(At this point I don't remember why I was intimidated by making PRs to rust-lang/rust. Folks have been nothing but lovely, and all feedback has been really good!)
3 replies 3 retweets 14 likesShow this thread -
Replying to @yoshuawuyts
Thanks for all these PRs, they look really useful!
1 reply 0 retweets 2 likes
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.
