Same
-
-
Replying to @kentcdodds @jxnblk and1 reply 1 retweet 8 likes
-
-
Replying to @kentcdodds @ryanlanciaux and
Before removing, I would maybe ask for help from MS TS team member. They have helped me soooo much with Formik. Cc
@drosenwasser1 reply 0 retweets 7 likes -
Replying to @jaredpalmer @kentcdodds and
Let me just start by saying having .d.ts files for your library is very valuable. They mean everyone gets a better experience (both for JavaScript & TypeScript). That said, unless your library is written in TypeScript, I think DefinitelyTyped is better for contributions.
2 replies 0 retweets 8 likes -
Replying to @drosenwasser @jaredpalmer and
I do like the benefits of having d.ts even in my non-TS projects. If I have an open source project that has types but is not typescript based -- the recommended path would be DefinitelyTyped just to avoid issues as noted?
1 reply 0 retweets 2 likes -
Replying to @ryanlanciaux @jaredpalmer and
There's a lot you have to think about. Do you know TypeScript? Have you thought about testing your declaration files? Have you thought about versioning? Are you willing to publish a patch version when changing a declaration file? DefinitelyTyped has this mostly thought out.
2 replies 0 retweets 3 likes -
Replying to @drosenwasser @ryanlanciaux and
These are good points and have been a source of pain for me. I'm pretty sure that at least 70% of the releases in glamorous have been TypeScript patch releases. TypeScript has also forced me to publish major version bumps before I wanted to.
1 reply 1 retweet 3 likes -
Replying to @kentcdodds @drosenwasser and
It also complicates the tooling setup because we do test the declaration files. These pains really add up when I don't use TypeScript myself. Luckily contributors are normally really helpful. But still, I don't like having to publish TS-only major version bumps :-/
1 reply 0 retweets 1 like -
Replying to @kentcdodds @drosenwasser and
If you're publishing TS files for convenience (as opposed to using TS directly), and these major bumps are frequent, I'd say don't bump majors unless you'd want to for JS and make the consequences clear to TS users.
2 replies 0 retweets 7 likes
In practice, this means that a semver minor bump might break types, but it will not break runtime code, and as a TS user I'd take that compromise (and the extra cost of minor version upgrades) any day over you feeling that TS users are a burden.
-
-
Replying to @wycats @drosenwasser and
Thanks Yedhuda. I think I may do that in the future
0 replies 0 retweets 3 likesThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.