We should look at this use case to see if "constructor replacement" is a feature we need to add back.
-
-
Replying to @wycats @dan_abramov and
Following up here -- is there any update on this discussion (constructor replacement) or somewhere I can follow the discussion?
@wycats1 reply 0 retweets 1 like -
I can't speak for
@wycats, but I believe all decorators proposals allow constructor replacement. The only question is, how ergonomically?2 replies 0 retweets 1 like -
Replying to @littledan @tizmagik and
I believe he said the current proposal requires changes (being worked on) for total replacement.
2 replies 0 retweets 0 likes -
Replying to @AdamRackis @tizmagik and
Replacement has a subclass check. Should I eliminate that? Are there other changes to make?
1 reply 0 retweets 1 like -
Replying to @littledan @tizmagik and
Yes definitely. Existing things like
@observer spit back a totally different class.2 replies 0 retweets 0 likes -
Replying to @AdamRackis @tizmagik and
Having trouble understanding; doesn't this spit back a different function or the same class?https://github.com/mobxjs/mobx-react/blob/master/src/observer.js#L274 …
1 reply 0 retweets 0 likes -
Replying to @littledan @tizmagik and
If I'm understanding correctly, that always winds up here. Note the resulting class Injector does not extend orighttps://github.com/mobxjs/mobx-react/blob/master/src/inject.js#L34 …
1 reply 0 retweets 0 likes -
Replying to @AdamRackis @littledan and
/cc
@mweststrate - Dan is asking about your observer decorator.2 replies 0 retweets 0 likes -
Replying to @AdamRackis @tizmagik and
Either way, filed a bug to remove the check. Thanks for the help here! https://github.com/tc39/proposal-unified-class-features/issues/21 …
3 replies 0 retweets 5 likes
After a lot of discussion with existing decorator users, I agree 
-
-
Replying to @wycats @AdamRackis and
Landed a fix: https://github.com/tc39/proposal-unified-class-features/commit/be349d25920e6d3297a9b02d2bfb670e6ab4fc94 … . 10 points for explaining the issue. Next time, you get 20 if you file a bug or 30 write a PR!
2 replies 0 retweets 5 likes -
Replying to @littledan @AdamRackis and
I'll take the 10 and shoot for 20 next time
0 replies 0 retweets 1 like
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.