I still don’t understand why everyone blocks their CI on unimportant formatting lints
-
-
*raises hand*
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
-
-
it's nice for reviewers to not have to fuss about style and to let them focus on more important details like if something should be as_mut_thing or as_thing_mut
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
-
-
If you don't see a problem, just add a git hook to rustfmt your changes on commit or at least push. Having a consistent formatting reduces clutter in the diffs and aids review.
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
-
-
I want consistent formatting, and I want git history to be clear and concise. I also don't want to deal with style debates. Having a style linter in CI is a very low effort fix for all of the above. Maybe adding a bot you can summon on a PR that fixes commits would help?
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
-
-
looks like this account is hacked
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
-
-
Some contributors will want to run cargo fmt on their code, and it’ll touch unrelated code in the PR if it wasn’t already formatted right. Also, sometimes the formatter is wrong and manual intervention is needed. Best to do it on a per contribution basis.
Hvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
Čini se da učitavanje traje već neko vrijeme.
Twitter je možda preopterećen ili ima kratkotrajnih poteškoća u radu. Pokušajte ponovno ili potražite dodatne informacije u odjeljku Status Twittera.