In my rush to get my renderer feature-complete, I haven’t had time to take a look, but I’ll do so now.
-
-
I think this is still very useful; it’s nice to have the IO stuff factored separately, and I think it’ll work nicely with the Metal renderer. My only concern is the coupling to NSOpenGLView; it doesn’t seem essential (could just be NSWindow)?
1 reply 0 retweets 0 likes -
Replying to @warrenm
Yes this probably ought to be fixed. The whole _osx.mm codebase probably needs feedback from actual Apple users (it's not merged because unfinished and had no one looking at it, if it plugged nicely into e.g. your example I would merge it).
1 reply 0 retweets 0 likes -
Replying to @ocornut
I created a metal-on-osx branch from my metal branch that incorporates impl_osx with some changes (flipped coords, removed ref to NSOpenGLView, small tweaks to mouse handling) and it’s looking viable. Feel free to pull and test (still WIP, though): https://github.com/warrenm/imgui/tree/metal-on-osx …
1 reply 0 retweets 0 likes -
Replying to @warrenm
Thanks! Does the event handling design looks decent to you? As in, possible to plug in the http://osx.mm code in a casual codebase?
2 replies 0 retweets 0 likes -
I'll run it but can't really provide critical feedback on many aspects since I am Apple-illiterate. I can however write down the feedback I have, if you are interested in polishing it into a PR?
1 reply 0 retweets 0 likes -
Replying to @ocornut
I am, and I’m happy to maintain it (as time allows) if there are issues. Maybe we can land impl_osx on master, then merge impl_metal as a separate PR after?
1 reply 0 retweets 0 likes -
Replying to @warrenm
Here's some feedback --> https://pastebin.com/svBzy9qh As for merge timing, depends on how you think your impl_metal is. Perhaps having it merged earlier would be a good strategy to obtain feedback from users?
1 reply 0 retweets 0 likes -
Replying to @ocornut
I’ve tried to resolve your (very helpful) feedback items: https://pastebin.com/A0un0GzZ I’m feeling pretty comfortable about experimentally introducing impl_metal upstream for comment.
1 reply 0 retweets 0 likes -
Replying to @warrenm
Looking good!! thanks. Yeah I am happy to merge! (minor header edit, posted here: https://pastebin.com/S07shggu ) feel free to make a PR and you can tag #1873 in the description text and commit text.
2 replies 0 retweets 0 likes
And here we are!https://github.com/ocornut/imgui/pull/1929 …
-
-
Replying to @warrenm
Thanks! Will try to look at it tomorrow if not this week-end!
0 replies 0 retweets 1 likeThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.