Thanks! Can't comment on Metal usage. The ideal is to maximize the amount of stuff that people can reuse directly (aka imgui_impl_metal) in their existing codebase, so additional params are totally ok, probably better to be explicit if it provides more flexibility?
-
Here's some feedback --> https://pastebin.com/svBzy9qh As for merge timing, depends on how you think your impl_metal is. Perhaps having it merged earlier would be a good strategy to obtain feedback from users?
I’ve tried to resolve your (very helpful) feedback items: https://pastebin.com/A0un0GzZ I’m feeling pretty comfortable about experimentally introducing impl_metal upstream for comment.
-
-
Looking good!! thanks. Yeah I am happy to merge! (minor header edit, posted here: https://pastebin.com/S07shggu ) feel free to make a PR and you can tag #1873 in the description text and commit text.
-
Nice! This’ll have to wait till later in the day, though. I’m too exhausted to trust myself to do it correctly at the moment. Do you want this as a PR based on the existing osx branch?
-
That would be ideal but not required if it’s git-confusing. And no hurry at all, thanks :)
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.