Warren Moore

Something to be mindful that may alter your Metal design is: in 'viewport' branch, the _binding_ code are able to create windows & rendering contexts. So hypothetical imgui_impl_metal in 'master' would handle 1 user-created Metal context, in 'viewport' branch can create more,

How it affected the Vulkan backend is simply that some of the helper/cruft required to setup the context instead of being in main.cpp (example code) are provided as helpers in the binding code so main.cpp can use them and binding also uses them to create secondary windows.

I would advise glancing then ignoring 'viewport' branch for now, because it really makes things a little more complicated, and having a working Metal renderer in 'master' would be immediately and readily useful as a first step.

Thanks! Can't comment on Metal usage. The ideal is to maximize the amount of stuff that people can reuse directly (aka imgui_impl_metal) in their existing codebase, so additional params are totally ok, probably better to be explicit if it provides more flexibility?

Do think imgui_impl_osx.mm is not useful then? or hadn't had time to look at it? (I'll ditch the icons and replace them with empty and optimized PNG files before squashing+merging so it doesn't get added to git repo size, they are not needed)

In my rush to get my renderer feature-complete, I haven’t had time to take a look, but I’ll do so now.