Warren Moore

Thanks! Can't comment on Metal usage. The ideal is to maximize the amount of stuff that people can reuse directly (aka imgui_impl_metal) in their existing codebase, so additional params are totally ok, probably better to be explicit if it provides more flexibility?

Do think imgui_impl_osx.mm is not useful then? or hadn't had time to look at it? (I'll ditch the icons and replace them with empty and optimized PNG files before squashing+merging so it doesn't get added to git repo size, they are not needed)

In my rush to get my renderer feature-complete, I haven’t had time to take a look, but I’ll do so now.

I think this is still very useful; it’s nice to have the IO stuff factored separately, and I think it’ll work nicely with the Metal renderer. My only concern is the coupling to NSOpenGLView; it doesn’t seem essential (could just be NSWindow)?

Yes this probably ought to be fixed. The whole _osx.mm codebase probably needs feedback from actual Apple users (it's not merged because unfinished and had no one looking at it, if it plugged nicely into e.g. your example I would merge it).

I created a metal-on-osx branch from my metal branch that incorporates impl_osx with some changes (flipped coords, removed ref to NSOpenGLView, small tweaks to mouse handling) and it’s looking viable. Feel free to pull and test (still WIP, though): https://github.com/warrenm/imgui/tree/metal-on-osx …

Thanks! Does the event handling design looks decent to you? As in, possible to plug in the http://osx.mm  code in a casual codebase?

Thanks! I can't really test super often myself but I'll borrow my wife's laptop to test at some point.

Sure thing! It’s still in-progress (doesn’t recycle buffers, and a lot of IO stuff isn’t wired up), and I haven’t taken your architectural suggestions into account, but I’m happy with today’s progress.