Look at all these cowards faving this. Openly question the orthodoxy sheeple! I'm a manager my opinion doesn't matter anymore!
-
-
Prikaži ovu nit
-
It's funny that every time I troll tweet about code review I can basically predict the responses: Googlers defend it A bunch of comments about it depends (yes obviously) A few people 10+ years younger than me claim it could never be otherwise Pair programming
Prikaži ovu nit
Kraj razgovora
Novi razgovor -
-
-
Code review (on both sides) is very powerful way to improve as an engineer. I started doing it intermittently in about 2002 and it’s been a requirement since 2008.
-
Whooooo is this tweet foooorrrrr
- Još 4 druga odgovora
Novi razgovor -
-
-
If your code reviews aren't valuable, you probably don't have machines doing enough of the work for you. Style, lint, build, test, coverage can be automated. Review is about knowledge sharing.
-
If the machine catches all of this and the majority of changes are small, how much knowledge sharing benefit are you really getting? This sounds like a great argument against mandatory code review. Save it for the times you actually need knowledge sharing.
- Još 8 drugih odgovora
Novi razgovor -
-
-
Have you ever seen it be *actually* mandatory? I've usually seen it where some people follow the rule and wait days (weeks?) to get review and ship their code and other people skip the code review and their only consequence is being able to do their job.
-
Yes, it is mandatory in OpenJDK. (And, before you roll your eyes and say something snarky about Java, think about how many times in the last 20 years the JVM crashed on you. That sort of reliability doesn't happen by accident.)
- Još 3 druga odgovora
Novi razgovor -
-
-
i don't get it. to me, code review is the primary vehicle for knowledge sharing and learning in a healthy team. maybe it's not necessary if you're at a company where engineers pair 8 hours a day but that seems like the exception, not the rule
-
it's almost as if they're trying to hoard knowledge and responsibility

- Još 7 drugih odgovora
Novi razgovor -
Čini se da učitavanje traje već neko vrijeme.
Twitter je možda preopterećen ili ima kratkotrajnih poteškoća u radu. Pokušajte ponovno ili potražite dodatne informacije u odjeljku Status Twittera.