It's not about my patch, it's about the fact that they use stock WebRTC from Google that has no CBR support.
-
-
so you're saying that all their platform code doesn't support CBR even though they blogged about it and this is still the case?
1 reply 0 retweets 0 likes -
Certainly on iOS. Build instructions suggests they still use stock WebRTC:https://github.com/WhisperSystems/Signal-iOS/blob/master/BUILDING.md#building-webrtc …
1 reply 0 retweets 1 like -
these are just build instructions. I can't verify this statement as I don't have a current Apple dev account.
1 reply 0 retweets 0 likes -
Raphael Robert Retweeted Raphael Robert
All you need is Wireshark:https://twitter.com/raphaelrobert/status/846370490923044864 …
Raphael Robert added,
1 reply 0 retweets 2 likes -
I've read the thread - that's not my point. ideally I'd like to verify the current source base. but it's too much of a hassle anyway ;)
1 reply 0 retweets 0 likes -
Pretty straight forward actually: look for a piece of code that parses "cbr=1".
1 reply 0 retweets 0 likes -
not really as I don't know what Signal ships to the app store in the `carthage` dir.
1 reply 0 retweets 2 likes -
Replying to @a_z_e_t @raphaelrobert and
That SDP munging is just belt and suspenders, CBR is hard coded in Signal.
1 reply 1 retweet 3 likes -
Replying to @signalapp @a_z_e_t and
Hard to publish the full webrtc source since it's not just one repo, but we can put patches somewhere if that would be useful.
1 reply 1 retweet 4 likes
Now that we're no longer blacklisting hardware AEC there, CBR is the only change.
-
-
Replying to @signalapp @whispersystems and
azet Retweeted Raphael Robert
sure, public patches would be cool.
@raphaelrobert keeps telling me you're still using VBR:https://twitter.com/raphaelrobert/status/861883341259370496 …azet added,
1 reply 0 retweets 1 like -
Replying to @a_z_e_t @whispersystems and
Raphael Robert Retweeted Raphael Robert
1. Is your patch not open source? 2. Wireshark from Mar 27 clearly shows VBR, when did you patch?https://twitter.com/raphaelrobert/status/846370490923044864 …
Raphael Robert added,
0 replies 0 retweets 2 likes
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.