One thing that is incredibly frustrating about certain classes of changes is that I have to implement 90% of it to find out if it's worth it
Show this thread
-
Oh awesome. I guess this involves porting something from Diesel to AR?
This is moving our internal `Attribute` objects outside of Ruby's GC since they're tied to the lifetime of the AR::Base inst
-
-
Most things that are actually "porting" from Diesel end up getting written in Ruby. e.g. https://github.com/rails/arel/compare/f031a3b9aa6a8093802e0188abce58e0b997078e...bfb770dbcc8432b8d4c1824be0fb2b1ab1ce5d68 … is literally from Diesel
-
(https://github.com/rails/rails/commit/213796fb4936dce1da2f0c097a054e1af5c25c2c … is the corresponding Rails change and has more context)
End of conversation
New conversation -
-
-
Super interested to see how you made that refactor possible.
-
The short version is by re-implementing AttributeSet and AttributeSet::Builder in Rust, exposing Attribute rarely
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.