Please don't ever do this. Nobody wants to review a single massive +1600/-1600 PR. Split it up into small pieces. https://github.com/rust-lang-nursery/rand/pull/161 …
-
-
Replying to @sgrif
Hmm… I’d say that if the commits are carefully crafted (rewrite history!) with good commit messages, it’s not *necessarily* bad.
1 reply 0 retweets 0 likes -
Replying to @__chrismorgan
That is not the case here. And if it were, just submit each commit as a separate PR
1 reply 0 retweets 0 likes -
Replying to @sgrif
It depends. Sometimes you have massive changes that *could* stand alone but only *make sense* all together.
1 reply 0 retweets 1 like -
Replying to @__chrismorgan @sgrif
But if you’re an outside contributor this is practically never the case and I agree with your judgment.
2 replies 0 retweets 0 likes
Replying to @__chrismorgan
You should talk to the maintainers before taking on that amount of work anyway, at which point the changes do make sense on their own
6:39 AM - 30 Jul 2017
0 replies
0 retweets
1 like
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.