Please don't ever do this. Nobody wants to review a single massive +1600/-1600 PR. Split it up into small pieces. https://github.com/rust-lang-nursery/rand/pull/161 …
-
Hmm… I’d say that if the commits are carefully crafted (rewrite history!) with good commit messages, it’s not *necessarily* bad.
That is not the case here. And if it were, just submit each commit as a separate PR
-
-
It depends. Sometimes you have massive changes that *could* stand alone but only *make sense* all together.
-
But if you’re an outside contributor this is practically never the case and I agree with your judgment.
- 1 more reply
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.