Hmm… I’d say that if the commits are carefully crafted (rewrite history!) with good commit messages, it’s not *necessarily* bad.
Please don't ever do this. Nobody wants to review a single massive +1600/-1600 PR. Split it up into small pieces. https://github.com/rust-lang-nursery/rand/pull/161 …
-
-
-
That is not the case here. And if it were, just submit each commit as a separate PR
- 3 more replies
New conversation -
-
-
Even though each commit stands on its own here I still don't want to look. Just make 30 separate prs
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
This is practically a fork.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
im a bit out of the loop on the rand crate. was there a prior conversation/discussion before this PR?
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
:+1: merge it
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Seriously, splitting up big PRs into Deploy1-DeployX is an art form to master.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Less than 500 lines at a time max.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
At least they didn't squash the commits together like an animal.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.