The amount of context around a change (and thus the amount there is to say) is not a function of # of lines changed.https://github.com/rails/rails/commit/6a6c4c459106e2d9b76dd1233133a2bf30866ab0 …
-
@sgrif If you were to write a function that worked accurately in this case, what would its inputs be?
@mattlarraz amount of impact on consumers of the code changed (which is of course not objectively measurable)
-
-
@sgrif Sure, but is there a reasonable proxy? Also, surprised you can change something so big without having any tests fail -
@mattlarraz Ended up adding tests to ensure the old behavior failed in a later commit.
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.