Miss Dada  🏳️‍⚧️

I can't control every -sys crate out there

https://twitter.com/ManishEarth/status/1295729273857167360 …

i.e., i can use it in *my* sys crates

Right, I get that. But there's a ton of code out there that doesn't or won't know to do this.

right, i don't dispute that :) i agree that CString cannot be deprecated, it is useful in far too many ways and for cases like the one you say before, my original point in this thread was that CString cannot be deprecated

Right. What I'd love to see is a change that removes the footgun for everyone (which does imply deprecating as_ptr), but doing that in a way which interops with existing code taking *const char and resists misuse is important

Any solution which requires you to know about the footgun and actively do something to avoid it isn't any better than the current situation

That's true. I think replacing as_ptr with an &*const c_char method could be good but it does have some similar issues