hmm, very on the fence about using polymorphism vs making it explicit that Rc::clone(&foo) copies a pointer vs foo.clone(), which, uh, might do anything, idk?
Clippy actually warns by default if you use `foo.clone()` instead of `Rc::clone`. IMO using `clone` instead of `retain` or something explicit was a mistake
-
-
what's retain?
-
(I've been trying to write Rc::clone when that's what I mean, as I think TRPL advises this?)
- 1 more reply
New conversation -
-
-
I'm not seeing clippy warnings when I do this deliberately
-
Looks like it's allow by default. Not sure which group it's in, but it's one of the ones we have turned on for Diesel. https://rust-lang.github.io/rust-clippy/master/#clone_on_ref_ptr …
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.