I sped up Rails total response time by 5% with a 5 line change: https://github.com/rails/rails/pull/33835 … 




-
Show this thread
-
Looks like I was wrong. 5% is the lower bound based on memory allocation. I ran the benchmarks and saw that the number is closer to a 17% decrease in total execution time! Which ain't bad.https://github.com/rails/rails/pull/33835#issuecomment-419951363 …
2 replies 1 retweet 12 likesShow this thread -
The ACTUAL number i'm seeing is 11.5% reduction in total request time that I can claim with statistical certainty is a result of my patchhttps://github.com/rails/rails/pull/33835#issuecomment-420376552 …
1 reply 0 retweets 3 likesShow this thread -
It's not 17% but geez. 11% performance bump for my OVERALL application speed from a 5 line change in a dependency (Rails) is way more than I was hoping for when I opened the patch.
1 reply 0 retweets 4 likesShow this thread -
Replying to @schneems
I think the discussion around this PR has been a great example of the complexities of OSS honestly, I suspect we'll end up merging it, but a great example of where a change has a lot more tradeoffs than might be immediately apparent
1 reply 1 retweet 7 likes -
Replying to @sgrif
100% agree. I don’t think anyone raised any concerns with the initial modification in 5.2.1. Got totally missed.
1 reply 0 retweets 0 likes -
Replying to @schneems
Did you mean 5.2.0? I'm honestly not sure I know about the issue with 5.2.1
1 reply 0 retweets 0 likes -
Replying to @sgrif
The commit I linked was from 5.2.1 but I re read and it claims it was preserving behavior.
1 reply 0 retweets 0 likes -
Replying to @schneems
Ah the commit in your original price description. Yeah, this is definitely why I'm pushing so hard on "hey let's make sure we know for sure if we break caches in the future" (that commit has no excuse for not being caught tbh)
1 reply 0 retweets 0 likes -
The commit in the description was introduced before 5.2.0.beta1
1 reply 0 retweets 0 likes
That makes me feel better. (Can't tell from my phone)
-
-
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.