Miss Dada  🏳️‍⚧️

I know that’s a major reason why I don’t use them more often. I was bitten by reject vs reject! In one of my more notable “oh shit. I just broke everything” events.https://twitter.com/nateberkopec/status/1038125248045047809 …

Happens to me w/map! and compact! constantly.

Is there a reason to prefer the destructive/! version other than performance (because Ruby)? My default is to use non-destructive methods and treat collections immutable/append-only. Defer optimization.

Agree. I've had very few cases in apps where the reduced allocations of the `!` methods mattered. However, I also see people intentionally use the ! methods for their different returns which makes the code hard for me to understand.

We really got a big speedup on the sentry-raven gem with `!` methods, because half of that gem's work is essentially putting very large hashes through a series of mutations. When you need !, you really really need it.

Gems are an entirely different animal though. They tend to have hotter hot paths than app code, and are more likely to live in the hot path than not. Plus as an author of a gem you have more of a responsibility to your users to pay attention to perf