Miss Dada  🏳️‍⚧️

I believe that the testing harness is set up with some special configuration for crates that require system libraries. I'm not sure what you mean about enabling features -- are there critical crates that literally don't work with the default feature set? Windows point is legit.

None of diesel_cli, diesel_infer_schema, or diesel_migrations work without a feature enabled

Have you talked to the Infra Team about getting this to work?

I haven't. I didn't think it was a large enough priority to bring up. I can bring it up on Tuesday if you think it's worth doing

If you feel worried that we're not getting a sufficient sample of the ecosystem on this basis, then it seems worth reaching out.

Including Windows specific crates would be a much higher priority IMO. It's not that I'm worried that we aren't getting a sufficient sample, I just don't think we should pretend that it's more than exactly that: A sufficiently large sample

OK, I was concerned because you were talking about putting "too much trust" in a Crater run, but if you feel like it's by-and-large a sufficient sample (which I believe as well), then I think it's just a question of precise phrasing, which I don't care much about here.

I definitely don't think a crater run should be used as a justification for a breaking change, since not all Rust code is open source, and not all open source code is on http://crates.io . But for what it is trying to do, I think it's definitely a good sample