> Spents his day trying to understand a CI regression on Darwin
> Finds this commit https://gitlab.haskell.org/ghc/ghc/commit/d46a72e19e1b508358827e7270139f3273915697 …
> 
-
-
Meanwhile I had success with fixing typos, Darwin is green! This is the glorious diff: https://gitlab.haskell.org/ghc/ghc/merge_requests/2192/diffs?diff_id=10772&start_sha=c443cd5c1d989de21c204bd8acfd74992eb680fa … That's it, I'll go home crying for the rest of the weekend
Prikaži ovu nitHvala. Twitter će to iskoristiti za poboljšanje vaše vremenske crte. PoništiPoništi
-
-
-
Oh wow, this is stupid. Two thoughts: - Perhaps updating perf test results via commit messages was not the best idea. We don't do this for correctness tests, why do it for perf tests? - This commit message should've mentioned that in the very first line that it fixes perf tests.
-
I'm not opposed to updating perf tests in commit messages. Sometimes there are increases caused by a bug fix that crucially needs to do more because of correctness. And performance should never be a reason to reject correctness.
- Još 1 odgovor
Novi razgovor -
Čini se da učitavanje traje već neko vrijeme.
Twitter je možda preopterećen ili ima kratkotrajnih poteškoća u radu. Pokušajte ponovno ili potražite dodatne informacije u odjeljku Status Twittera.