Unfortunately we've had to disable @yarnpkg PnP at Facebook due to instability. We'd recommend thorough testing before deciding to adopt it in your codebase.
-
-
What were the biggest obstacles / sources of issues?
1 reply 0 retweets 12 likes -
2 replies 0 retweets 5 likes
-
For context, our JS setup for RN is gigantic. There is tons of custom JS infrastructure, most of which makes more or less sense or was born out of necessity.
1 reply 0 retweets 7 likes -
PnP is a fantastic idea but it was never fully deployed at Facebook. Two important tools like Flow and Buck didn’t receive proper PnP support. When engineers ran those, which at FB anyone writing JS will often, Yarn would opt out of PnP and do a full node modules install.
2 replies 0 retweets 11 likes -
As most people triggered at least one full node modules install because of this, we didn’t gain the performance advantages (no install time) that we wanted, we just deferred it. In some cases it was even worse, doing more node modules installs than necessary.
1 reply 0 retweets 8 likes -
The second major issue was frequent ecosystem incompatibility with third party packages. It takes a lot of work to keep things stable and active maintenance but unfortunately we didn’t have time to maintain this infra.
1 reply 0 retweets 8 likes -
The other major improvement PnP brings next to perf is reducing fs operations which is desirable within FB’s source control. I’d love to give PnP a try in the future when it’s more stable and hopefully requires fewer changes and maintenance but now is not the time for us.
2 replies 0 retweets 5 likes -
Your setup may be vastly different and more simple and you may not run into these issues that we did. I think it would be for the better if the ecosystem migrated to a stricter and install-less format for storing third party modules.
2 replies 1 retweet 8 likes
-
-
0 replies 0 retweets 5 likesThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.
he/him 