Unpopular opinion: @reactjs edition
Bring it on 
-
-
Replying to @dan_abramov @reactjs
React code base, especially post-fiber, is extremely hard to grok, and the Facebook idiomatic code style is obnoxious af
2 replies 0 retweets 21 likes -
What Facebook idomatic code style are you referring to? Dunno if you're making assumptions, or have seen that code style in other FB open source?
1 reply 0 retweets 1 like -
I'm making assumptions slash communicating imprecisely. It might be just React idiom, though based on my hazy memory some style choices, like usage of invariant etc utilities are shared across multiple FB OSS projects.
2 replies 0 retweets 3 likes -
Stuff like invariant isn’t important. We actually wanted to cut that out. There’s some legit constraints (the way data flow is structured), some intentional culture (longer names, relatively large procedural functions), and some accidental stuff which can go (like invariant).
2 replies 0 retweets 4 likes -
invariant is overused in FB/Flow projects due to refinements
2 replies 1 retweet 8 likes -
Replying to @sebmck @dan_abramov and
it was used plenty before flow too (:
1 reply 0 retweets 2 likes
At least then the motivations would have been better, right? Setting expectations and asserting impossible conditions rather than purely type system satisfaction? I find I dislike using invariants/assertions because I’m burnt out by refinements.
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.
he/him 