This is a really frustrating Clojure benchmark. Wish the developers would accept patches for things like this.https://gist.github.com/nathanmarz/9d8805d5e7d9c689cd629bd0551e84f1 …
-
-
Replying to @nathanmarz
given that you have not provided a discussion, a ticket, or a patch this seems pretty disingenuous. also see gist for comments
1 reply 0 retweets 8 likes -
Replying to @puredanger
I tried to provide a really simple patch to "constantly" and was told the performance wasn't important
2 replies 0 retweets 0 likes -
Replying to @nathanmarz
So because one suggestion (which I see no record of) wasn't accepted, you assume unrelated changes will never be accepted? Seems weird.
1 reply 0 retweets 1 like -
Replying to @puredanger
It was in Slack. And that's a much simpler change (unrolling fn). At the time you rejected idea because it would be "more code to maintain".
2 replies 0 retweets 0 likes -
Replying to @nathanmarz @puredanger
If you're going to reject something so simple to improve perf, why should I expect a more complicated change to improve perf be considered?
1 reply 0 retweets 0 likes -
Replying to @nathanmarz
Because every change (esp perf) has its own set of tradeoffs to weigh wrt to complexity, maintainability, frequency of use, etc
1 reply 0 retweets 3 likes -
Replying to @puredanger
https://clojurians-log.clojureverse.org/clojure-dev/2016-06-23.html … Somehow I remember the suggestion being more firmly rejected, so my earlier tweet is too strongly worded
2 replies 0 retweets 0 likes -
Replying to @nathanmarz @puredanger
Would a patch to constantly be accepted? first is a more complicated discussion since there's other philosophical points to debate
2 replies 0 retweets 0 likes -
Replying to @nathanmarz @puredanger
Data point: I use constantly quite a bit. A pattern that ends up on the hot path is (constantly 1) as stand-in for optional weight vectors.
1 reply 0 retweets 0 likes
granted if it's performance critical it will get partially compiled anyhow, but would be a nice perk for awkwardly sized data.
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.