the result respecter
Wooji Juice
@rpy @olebegemann I've found that setting tintColor on the view manually before adding it to the hierarchy helps a lot.
My discovery for the day is iOS has an O(n^2) cost to add a subview so never have too many subviews on a view or performance goes to shit
-
-
- View other replies
-
@wooji@olebegemann great call, just tested out setting tintColor on the subviews before adding and found CPU time went from 980ms to 110ms - View other replies
-
@rpy@olebegemann@wooji That's incredible. Maybe a UIView category that sets tintColor on init to some app-wide standard?
-
-
-
@rpy@nicklockwood the UITintColorVisitor has an extremely inefficient implementation that searches for subview via “contains:” - View other replies
-
@benjaminencz yup that’s exactly where i ended up. can’t find the exact conditions it gets invoked in but setting tintColor avoids it -
@rpy I've started a short blog post investigating this. Seems like I should finish & publish
-
@benjaminencz if you don’t i’m inclined to, seems folks are interested and i took a lot of notes analysing it today -
@rpy I'll try to wrap it up tonight. But don't want to stop you from blogging! could compare notes though.
-
-
-
@rpy oh ……………………………………………………………………………………………………………………………………………………………………………………………………………………………………………………………………………………………… How many is too many? -
@karlbowden depends, i hit trouble at about 300. the more you add, the more you risk running into this blokepic.twitter.com/7VlcBfZW71
-
@rpy ooooooooo. Oh. Time I rethought displaying a year’s worth of days as UIViews maybe….#JankAllTheThings -
@karlbowden stuff them into some sort of hierarchy rather than all being descendents of a single view and you are
-
@rpy haha. Month grouping it is then.
-
-
-
@rpy@olebegemann Sounds like The Magic of AutoLayout to me. -
@fzwob@willemkokke wasn’t using autolayout in this case, it’s to do with the mechanism that propagates tint changeshttps://twitter.com/rpy/status/729573811348066305 …
- View other replies
-
@rpy@olebegemann@fzwob@willemkokke Yeah, auto layout is pretty fast as long as you don't add all your views & constraints at once
-
-
-
@rpy oh wow, that is super strange but explains things -
@taybenlor me debugging the workings of-[UITintColorVisitor visitView:]: view has 244 subviews and it runs containsObject: 244 times, hmmmm
-
-
-
@rpy Have you filed a radar? -
@jamieforrest haven't had time to create a sample project and file one yet but will do
-
Mike Rundle
Benjamin Encz
karlBowden.async()
Friedrich Markgraf
Martin Pilkington
Jamie Forrest
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.