If I'm reviewing a Github PR and have nits (like a missing article in a comment, say), I wish I could just directly edit the PR and merge it without having to pull it into a local repo, etc...
-
-
Replying to @really_bz
This is a feature!https://github.blog/2014-01-21-web-flow-editing-from-pull-requests/ …
2 replies 0 retweets 0 likes -
Replying to @garrettr_
So... on https://github.com/heycam/webidl/pull/756/files … I do not see the UI that article shows, with the Open/Edit/View buttons....
1 reply 0 retweets 0 likes -
Replying to @really_bz @garrettr_
May I am not looking in the right place? The screenshot is pretty cropped, so I'm not sure where I should be looking. I see an "Edit" button for the PR title, and a "Viewed" checkbox for the one file involved, and a "..." next to that checkbox, but nothing like the linked UI.
1 reply 0 retweets 0 likes -
Replying to @really_bz
Sorry for the late reply! Open the PR and click the Files Changed tab. Each file has a header with an ellipsis icon on the right. Click that, then "Edit file" if it's enabled.pic.twitter.com/JNl1WvJQ6v
1 reply 0 retweets 1 like
Aha, perfect. Not very discoverable, but perfect. ;)
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.