Boy it's hard to get people to take conceptual corrections at the point of a code review.
-
-
Replying to @peidran
Agreed. When code has been written and is working is too late to discuss conceptual approach. Do you use RFC diffs/pull requests?
1 reply 0 retweets 3 likes -
-
Replying to @peidran
I've found that teams can benefit from habitually putting up very early, request-for-comment diffs, maybe even just comments/pseudo-code.
2 replies 1 retweet 7 likes
Replying to @oerhoert
Totally. I try to do this, but often forget. Nobody else tries. I'm not in a position to mandate it. I just feel like a jerk when reviewing.
1:21 PM - 12 Jul 2017
from San Francisco, CA
0 replies
0 retweets
10 likes
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.