so much "this meeting should be an email" but not enough "this pull request with 35+ comments and counting should be a meeting where yall look each other in the fucking eye"
-
-
Replying to @arshia__
more code reviews esp for big features & design changes should be gone over in person idk why ppl are so allergic to this!!
3 replies 2 retweets 69 likes -
I have no idea how I would do this. Screen share while I leave comments? Leave the comments first but leave them pending and then screen share? Both of those sound like they could come off as mean, like the problems are bad enough to warrant a call or something.
1 reply 0 retweets 0 likes -
The tools aren’t perfect but yes, I make pending comments, in part to give myself the space to engage with the code and articulate my feelings. Often those comments are mooted by the conversation and I drop them. They’re still worth writing.
1 reply 0 retweets 1 like -
Replying to @peidran @ZiggyTheHamster and
If I keep them, the conversation gives me a chance to introduce the PR comments, my motivations, how much I care, that I’m not trying to be a dick, etc, in a way that’s hard to do well in writing.
1 reply 0 retweets 1 like -
Do you schedule a call, or do you just say "hey, let me know when you have time to talk about your PR before I submit a review"? I worry that wanting to interrupt someone with a call would come across like they really fucked up when probably it was my unclear direction
1 reply 0 retweets 0 likes -
Usually I'm working with someone in person, but yes. People are regularly apprehensive. If you do it right away, and consistently over time for PRs that set a lot of precedent, then it's less scary.
1 reply 0 retweets 1 like -
Replying to @peidran @ZiggyTheHamster and
Engineers don't start out knowing how to talk about their code, the decisions they've made, the alternatives. It's absolutely essential to their development.
1 reply 0 retweets 2 likes -
Replying to @peidran @ZiggyTheHamster and
I should say: try to avoid these scenarios. If you do upfront design and scoping work, which you should, then the PR is usually an account of things you learned along the way, changes you've had to make.
1 reply 0 retweets 1 like
If it diverges significantly, or if the work is exploratory in nature, you (the author) should be engaging others actively for discussion, in the medium that will best let you engage around the open questions. That's part of ownership.
-
-
Replying to @peidran @ZiggyTheHamster and
Sorry, that was more than you asked for.
0 replies 0 retweets 1 likeThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.