Discuss: Which version is "better" and why? How would you solve this?pic.twitter.com/KLuwMPRsoo
Show this thread
-
If I was worried the comment was out of date I'd be checking the git blame to see if the implementation had changed without the comment changing. the shorter one was very easy to plug in to another language to check its function.
Let's assume it is brand new code. Someone checks in the line of code plus the comment. If there is a bug then your PRNG will have a slight bias. Which version would you prefer? Against which reference would you check in the other language?
-
-
the one with less magic constants. but you said 'PNRG' which makes me think this could be security related and I definitely don't have the confidence to review anything that sensitive.
-
In that case it isn't directly security related but it's a prerequisite (assumption) in a formal proof. I.e. if you get it wrong you might think you have proven correctness for something but haven't.
- Show replies
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.