Discuss: Which version is "better" and why? How would you solve this?pic.twitter.com/KLuwMPRsoo
Show this thread
-
I wasn't sure what they did until I wrote a perl one liner based on check_en_alt. That seemed the easiest to test. I'd go with that one and a comment on its purpose.
A comment would certainly help. :) But say you are reviewing someone elses code. Would you trust that the code always does what the comment says? How long would it take you to convince yourself that it is a bug free implementation?
-
-
If I was worried the comment was out of date I'd be checking the git blame to see if the implementation had changed without the comment changing. the shorter one was very easy to plug in to another language to check its function.
-
Let's assume it is brand new code. Someone checks in the line of code plus the comment. If there is a bug then your PRNG will have a slight bias. Which version would you prefer? Against which reference would you check in the other language?
- Show replies
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.