C Quiz time! What's wrong in this function?pic.twitter.com/Zsa3TbKv2q
Show this thread
Probably `!str->data` after realloc, but tbh what bothers me more is `new_len = len + 4096`. Probably want something like `new_len = 2*len` instead so we don't get quadratic runtime for algorithms that try to linearly increase a buffer size.
-
-
I was thinking of the first thing. The second thing is a good remark. Note that it has also been noted and answered that there is no overflow check but that allocation functions that fail above PTRDIFF_MAX make one unnecessary. *2 is ok, *3 would not be.
-
This Tweet is unavailable.
- Show replies
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.