for my very first code review, @stankyy_pete and I are going to review each others code and then write about the experience.
beginning #rstats coders: what are you most interested in learning about the process?
pros: what code review recommendations do you have?
-
-
Replying to @kierisi @stankyy_pete
When I review code, I avoid syntax/style corrections. Instead, is it clear what problem they are trying to solve (documentation)? Can I reproduce it? How have they proposed to solve it? How did they prove they solved it (test coverage)? What add'l problems might this introduce?
2 replies 3 retweets 8 likes -
and what edge cases have been overlooked / not tested! invisible if statements, assumptions, etc!
1 reply 1 retweet 3 likes -
Replying to @ctitusbrown @mmmpork and
ooh, and fuzzing - what happens if I toss in totally random input?
1 reply 1 retweet 4 likes -
Replying to @ctitusbrown @mmmpork and
I always think of this and wonder if it's an edge case worth worrying about?
2 replies 0 retweets 3 likes -
at the very least I put in assert statements so that when it happens, I know about it. Once I reuse code more than a few times, I inevitably discover that the edge cases matter in ways I didn't initially appreciate!
1 reply 0 retweets 4 likes -
Replying to @ctitusbrown @mmmpork and
This is very true, but I'm not it's happened to me in the "fuzzing" case you describe, more generally, yes, often. I think about fuzzing (didn't know the name before) but I wonder if it's ever needed to directly address.
2 replies 0 retweets 2 likes
*but I'm not SURE it's happened to me
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.