Is it private?
-
-
Replying to @o_guest @spinicist and
Current code is here https://github.com/cMadan/ElGateau/blob/master/dev_notebooks/ElGateau.py …
1 reply 0 retweets 2 likes -
Replying to @cMadan @spinicist and
Assuming from the non-PEP8 in some places, you might wanna use a linter? Also which is the function you wanna alias?
1 reply 0 retweets 1 like -
Replying to @o_guest @spinicist and
Yeah, I probably should use a linter soon, right now been going more for basic functionality and then improving docs and generalizability
2 replies 0 retweets 1 like -
KEY_BLANK was going to be an alias of icon_solid, but instead decided to make it a constant to make things more efficient
1 reply 0 retweets 0 likes -
Replying to @cMadan @spinicist and
I can't speak to the efficiency to be honest without getting to grips with your code more. But why are you using globals instead of a class?
2 replies 0 retweets 2 likes -
It is common and fine to use module-level constants. Advice against globals is about not writing to globals.
2 replies 0 retweets 1 like -
Replying to @michaelhoffman @o_guest and
Right, I definitely am not going to define anything as a global, just want some module level constants instead of hardcoding those values
1 reply 0 retweets 0 likes -
I do agree think a object-oriented interface would be more natural than passing an elg handle all over the place.
2 replies 0 retweets 3 likes -
Replying to @michaelhoffman @cMadan and
Once you figure that out, I'd suggest your class should act as a context manager so you can use it in a with block.https://www.python.org/dev/peps/pep-0343/ …
2 replies 1 retweet 2 likes
Yep! Exactly!
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.