TODO comments policy: use TODOs as temporary markers only, never commit them. Use FIXME for permanent markers, must have an issue number and a comment. Should be enforced in CI. Rust used to enforce this, but I don't think it does anymore. Sad.
Something I like: - Having the ability to add a marker (like TODO) that is rejected by CI Specifically, I like having the ability to communicate to the reviewer "this is broken in this commit but will be fixed by the end of this PR sequence" (else CI would be failing).
-
-
It's sort of interesting how often I think this is true, get to the end of the PR sequence, open the PR, and then find that I never did have to fix that TODO after all.
-
and/or wrote inadequate tests to expose the problem :)
- 1 more reply
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.