So impressive it makes me wonder where I messed up. Enjoy your vacation!
-
-
-
Replying to @dan_abramov
Looping in
@sebmarkbage &@soprano — any idea what might be causing this massive difference?1 reply 0 retweets 0 likes -
No idea. Have a flame chart or profile comparison?
2 replies 0 retweets 0 likes -
Replying to @sophiebits @soprano and
React v15.6.1: App: https://speedometer-react-15-6-1.now.sh/resources/todomvc/architecture-examples/react/ … Benchmark: https://speedometer-react-15-6-1.now.sh/InteractiveRunner.html?suite=React-TodoMVC&startAutomatically … ~25ms
2 replies 0 retweets 1 like -
Did something change about the way onChange works? This no longer triggers onChange after the update:
1 reply 0 retweets 0 likes -
element.dispatchEvent(new Event('change', { bubbles: true, cancelable: true }));
1 reply 0 retweets 0 likes -
Yes,
@monasticpanic changed how onChange polyfill works.1 reply 0 retweets 1 like -
Replying to @dan_abramov @soprano and
https://github.com/facebook/react/commit/045f1a791c6e17253e9d927ffca70ae5d00b4fe5#diff-2bead3a73555ca476b3dedf1f31fbb93R68 … matches the behavior that I’m seeing. However, I’m testing v15.6.1, which doesn’t seem to include this change
1 reply 0 retweets 0 likes -
It does (it was later cherry picked)
1 reply 0 retweets 0 likes
Thanks! Continuing the discussion here: https://github.com/facebook/react/pull/5746#issuecomment-323947947 …
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.
JavaScript, HTML, CSS, HTTP, performance, security, Bash, Unicode, i18n, macOS.
Have you tried 16 beta?