Hector Martin

(this thread is very stream of consciousness sorry) the game being implemented was two-player, but i realize that one useful constraint you /could/ abstract out is to make it N-player. even if you don't actually support that, avoiding hardcoding the player count shows foresight

- honestly i was really just looking for two things: thoughtfulness and attention to detail. i want to know you think about what you're doing and scrutinize it carefully some folks made the board the wrong size and hoo boy that made a bad first impression

like… you're trying to get a job here. this isn't a quick throwaway, this is you showing off the best possible work you can do in order to convince a company to give you absolute fucking boatloads of money approach it like you're on iron chef, not making pb&j on sunday morning

after overt breakages, the stuff i paid the most attention to was the stuff that's easy to fuck up with no obvious consequences /in this case/ — needless reliance on global state or metaprogramming, use of ancient apis, messy internals, copy/pasting

because if that's what you do when you know you're being judged and a lot is on the line, how much worse will it be day-to-day? (also my whole role was basically cleaning up everyone else's messes so i had a vested interest in cutting that stuff off proactively)

- this is pretty frontend-specific, but i was not fond of javascript that directly twiddled css properties. you should absolutely not be setting .style.backgroundColor to make a piece match the player's color. make it a class! and call the class .player1, not .blue!

how likely am i to want to change this? how hard would it be to change this? how much effort does it take to make this easier to change? if "somewhat", "very", and "almost none", fuckin do it then

- i saw some curious spelling issues. a lot of applicants had names that i assume are indian, and i'm not going to punish folks for learning english as a second language. godspeed, honestly. but a couple times i ran across cases that i could not quite explain