The latest version of psmisc broke *killall*. Seriously. It's been in Gentoo ~amd64 for a week and apparently I'm the first to notice?! https://bugs.gentoo.org/664480
Show this thread
-
I've seen killall be weird for the past week and I thought there must be some explanation... something about process names having full paths or not... maybe some security feature in the kernel... nope. Just a stupid, dumb bug.
Show this thread
Best part: the commit that introduced the bug is unreviewable, because the author had the brilliant idea of combining it with a complete whitespace reformatting of the entire file. Lovely. https://gitlab.com/psmisc/psmisc/commit/1e2f38a202798a78554ae5f5d12f697f3607f89f …
-
-
Come on
@smallsees, you can do better than that. This is commit hygiene 101. Don't mix totally unrelated stuff into one commit. *Especially* not a huge reformat.Show this thread -
I honestly am struggling to understand how you can write a commit to increase the command length beyond 15 characters... and then never try it on a command with more than 15 characters (or even 7)? Like, the feature wasn't even tested once? How does this happen?
Show this thread
End of conversation
New conversation -
-
-
This Tweet is unavailable.
-
That software has workarounds for sloppy source control practices doesn't make them not sloppy.
- Show replies
-
-
-
foo (char *comm, ...) { ... if (lencomm > sizeof comm -1) lencomm = sizeof comm -1; ... } No comments...
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.