Like, sorry, but there is *no* excuse for changing the size of core types on an established platform. That's a fucking massive ABI-breaking change. You just don't do that.
-
-
Just looked at the diff again and "s32/u32" went from being typedef "[unsigned] int" to typedef "long [unsigned] int". Not sure if that caused the aforementioned breakage, but that change alone was a major pain in the ass since it spewed warnings for basically every printf.pic.twitter.com/9kRdlhlgpj
1 reply 0 retweets 0 likes -
And yes I know both are 32 bits on this platform, but that doesn't mean they're freely interchangeable. And this isn't the only issue; basically every HBC release we've had where we updated libogc/devkitPro at the same time, we had to fix *some* breakage.
1 reply 0 retweets 0 likes -
Replying to @marcan42 @hedgeberg
Well *exactly* Marcan. It doesn't mean they're freely interchangeable and the warnings you refer to are because of somebody's code being written as if they are.
2 replies 0 retweets 0 likes -
Replying to @davejmurphy @hedgeberg
You mean "everybody's". This is platform-specific code. The convention for the libogc APIs is to return s32. There's no printf specifier for s32. There is one for int32_t (if you assume *that* mapping never changes), but who uses PRId32 for every single return code?
2 replies 0 retweets 0 likes -
The point is you don't just up and yank and change a core typedef out from under people without changing the platform specifier. You can argue the code makes non-portable assumptions all you want, but once a platform is defined, it's defined.
1 reply 0 retweets 0 likes -
Replying to @marcan42 @hedgeberg
I don't believe I "yanked a core typedef" though. I fixed a problem that threw up warnings which showed up a lot of places where daft assumptions were made. Ultimately it improved a lot of code. It also brought devkitPPC in to line with other newlib based toolchains.
1 reply 0 retweets 0 likes -
Running around badmouthing people behind their backs and encouraging abuse of people trying to do their best really isn't the way forward though.
1 reply 0 retweets 0 likes -
Replying to @davejmurphy @hedgeberg
Honestly, I don't think it's behind your back when you were tagged in the thread, and I don't see where I encouraged abuse? I criticized the product, that's it.
1 reply 0 retweets 0 likes -
Replying to @marcan42 @hedgeberg
Well this is a little infantile and offensive https://github.com/fail0verflow/hbc/search?q=devkitfail&unscoped_q=devkitfail … I noticed it the other day when I was doing this https://github.com/fail0verflow/hbc/compare/master...WinterMute:master … I neglected to make the PR because of that and 1001 other micro-aggressions about how "shit" devkitPPC is
1 reply 1 retweet 0 likes
Programmers sometimes vent in code, especially when it wasn't originally intended for release. FWIW, I didn't write that code, I just didn't notice it when I was cleaning up that tree. Is there anything else?
-
-
0 replies 0 retweets 1 likeThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.