Conversation

1/3 Yesterday a test of an unreleased advanced order type encountered a bug which resulted in the order's prices being matched against the wrong side of the book. Some clients bought from the tester at $8000 and others sold at $12000 without clearing the intervening liquidity.

124

205

Boban Milošević

@bobanmil

Sep 14, 2019

1. Whose idea was to run tests on your production environment? 2. Which "clients" had a chance to buy BTC at $8000 and sell at $12000, while the market price was around $10250?

This Tweet was deleted by the Tweet author. Learn more

Replying to

and

You’re arguing for going straight from test env to full public rollout without a production limited beta? You have to go to prod at some point. This particular feature had already seen thousands of tests over several months. This just reinforces our careful, staged approach.

8:38 PM · Sep 14, 2019Twitter for iPhone

Replying to

and

Are you kidding me? How is this a limited beta when those that never agreed to be beta testers are affected. 1. Say that you are sorry 2. Explain how you will repay those that had stoplosses triggered when they should not have and lost capital.

@krakenfx

@jespow

$btc

Lefteris Karapetsas | Hiring for @rotkiapp

Replying to

and

These things happen. There are bugs that won't be seen in a test environment no matter how many tests you have. You guys did well by introducing it in a staged approach. Nicely handled.

Replying to

and

If this was a careful staged approach, then it would not have happened.

Replying to

and

Having "order's prices being matched against the wrong side of the book" is a bug of critical severity. Are you saying that "thousands of tests over several months" passed this test case on staging environment, but somehow failed in production?

Boban Milošević

@bobanmil

Sep 14, 2019

No matter which "unreleased advanced order type" we're talking about here, your engine should simply not allow an order to be executed 20% above the lowest ask, or 20% below the highest bid. That's against the very fundamentals of how order books work.

Show replies

Replying to

and

If this feature was tested “thousands of time” over several months, then you need to hire better test engineers to uncover these corner cases. I would find out which clients bought btc for 8k as one is the culprit to trigger it.

Replying to

and

could you answer his questions, particularly the second?

Replying to

and

So what you’re saying is you and friends got to buy at 8k and sell at 12k, “production limited”

Replying to

and

i think when you wick 2000 dollars down to what is literally the bottom at 8k and orders get filled. there should be a rollback...unless of course they are your orders ;)