@jedisct1 Uncommented code will also be rejected.
Seriously, there is nothing more frustrating than having to make the code consistent with what’s already here before merging a PR.
-
-
-
@jeremiahfelt And debugging code leftovers / commented out code: https://github.com/jedisct1/libsodium-php/pull/10/files#diff-8c252efb4aceb23b66a8b49b48c4c516R897 … - That has nothing to do in a non-local git repos.
End of conversation
New conversation -
-
-
@jedisct1 here’s a life saver tip: don’t. People can fix their own pulls.Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
@jedisct1 I often add a target "indent" to any Makefile to achieve this.Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.