so much "this meeting should be an email" but not enough "this pull request with 35+ comments and counting should be a meeting where yall look each other in the fucking eye"
more code reviews esp for big features & design changes should be gone over in person idk why ppl are so allergic to this!!
-
-
Because that would be socially uncomfortable for the one senior engineer who would normally add 30 nits to the PR and complain that it wasn’t done their way
-
True. Also definitely have seen this cut both ways.
- 3 more replies
New conversation -
-
-
I have no idea how I would do this. Screen share while I leave comments? Leave the comments first but leave them pending and then screen share? Both of those sound like they could come off as mean, like the problems are bad enough to warrant a call or something.
-
The tools aren’t perfect but yes, I make pending comments, in part to give myself the space to engage with the code and articulate my feelings. Often those comments are mooted by the conversation and I drop them. They’re still worth writing.
- 7 more replies
New conversation -
-
-
At $PREVIOUS_EMPLOYER, we implemented code walkthroughs for big PRs, and within a few months people would just "intuitively" split new PRs into much smaller ones — though often chained, as was very hard to break the dep's between some of them. Made a huge difference to reviews!
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.