Greg Titus

@gregtitus beautiful! Can you get rid of the if statements inside the cases in insertValue() by using case…where?

@curtclifton Yes. Much prettier, thanks for the suggestion: https://gist.github.com/anonymous/931f4cc7fc60fc8396a6 …

@gregtitus sweet! Would it make sense to nest the def of TrieNode inside Trie class? Guess we don't really know the plan for encapsulation.

@curtclifton Maybe? I was thinking of Trie class being old way (pointer to mutable thing) and accessing TrieNode as new (immutable struct).

Now I have to figure out how to make Swift code fast. Fumbling around in a dark room feeling for light switches… But when you find them!

@gregtitus I wouldn't focus on trying to optimize right now. If you find slow things, file 'em and let the swift optimizer folks have a shot

@catfish_man I don't expect Swift to be fast right now, but getting a feel for what idioms are performant and what aren't is good learning.

@gregtitus yup, just be aware of when something is being skewed by a bug. Inner loop is 90% refcounting? Probably a bug not a slow pattern.

@catfish_man Yup, but who will appreciate the bug fixes without ppl like me. :) (protocol witnesses appears to be the slow bit atm, btw)

@gregtitus @siracusa that’s a property, but it’s type is an extension? How can extension be a type of an expression as different from String

@mgorbach @siracusa String.UnicodeScalarView is a type nested inside String. It's a string as represented by a sequence of UnicodeScalars.

@gregtitus is there a memory and perf comparison?

@evanlong Mem within 10%, perf is about 2x slower in Swift (compiled fastest/unchecked). Room to improve, but I'm happy with Swift so far.

@gregtitus Ahhh, good on mem. I saw the branching with dictionaries and was a red flag at first.

@gregtitus Maybe fewer lines of code is not a goal? Swift can promote unreadable code. The language is for the human, not the computer.

@eweu I mostly disagree. It's possible to be too terse, certainly, but there are zero bugs in the lines of code you don't write.

@gregtitus True but think about the obvious bug on one line vs. the subtle bug buried in some anonymous function on a one line zinger.