Just a heads up, your API sends a 500 internal server error when you try to list PR review requests on PRs with requests from teams.
-
-
-
Thanks for the heads up! Already got a fix on the way.
End of conversation
New conversation -
-
Finally!
Thanks. Twitter will use this to make your timeline better. Undo -
-
Can't ask for a review of individuals in the team anymore
-
You should still be able to! Please reach out at http://git.io/c with details so we can help! -SJ
End of conversation
New conversation -
-
-
Very interesting! What does the workflow look like for a user approving a team review?
-
if any user on that team approves, the requested review for that whole team is marked as satisfied
-
Do they have the option of choosing which team review to submit, if they’re on multiple teams?
-
i’m not sure! i haven’t personally seen someone try to submit a review for two teams
i thiiink it’d satisfy both but i’d have to check -
Fair enough, I’ll try it out myself!
IMHO I think providing a choice is good. Teams could represent cross-cutting concerns -
And a reviewer might
from one perspective but
from another. Or leave review to someone else.
End of conversation
New conversation -
-
-
That is great! But I still don't see the team requests on my list of Review Requests (https://github.com/pulls/review-requested …)
End of conversation
New conversation -
-
wow it's awesome, would this also be supported on the api? would be more useful!
Thanks. Twitter will use this to make your timeline better. Undo -
@yahilmadakiya take a note ;)Thanks. Twitter will use this to make your timeline better. Undo -
Nice work
@githubThanks. Twitter will use this to make your timeline better. Undo -
Thanks. Twitter will use this to make your timeline better. Undo
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.