-
-
is there anything that automates the addition of PR-URL?
2 replies 0 retweets 1 like -
Replying to @b0neskull @MylesBorins and
wow, it’s incredibly awkward to work backwards from a commit to figure out what PR it came from.
1 reply 0 retweets 1 like -
Doesn't the pr url just tell you that?
1 reply 0 retweets 2 likes -
no, rather, I mean, without it
1 reply 0 retweets 2 likes -
Yes I've started including a PR link in all my commits, just because the #54 style link in other GitHub repos stops being useful if you move the repo somewhere else. Also when people use the default Github merge, only the top commit gets that link.
1 reply 0 retweets 1 like -
Replying to @gibfahn @b0neskull and
Metadata can be auto-generated by `git node metadata`: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata …
2 replies 0 retweets 1 like -
Whaaat I've been using "get-metadata"
@JoyeeCheung is a wizard1 reply 0 retweets 2 likes -
Replying to @MylesBorins @b0neskull and
Have you tried out `git node land` yet? It even checks CI status. Some very cool stuff going on in that repo. Really cool to see so many new contributors getting involved there too. https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-land …
1 reply 1 retweet 4 likes -
Replying to @gibfahn @MylesBorins and
but still, you have to start with the PR, you can’t just start with a commit SHA, and that sucks. it seems like git’s “notes” capability would allow this metadata to be stuffed into a commit...
1 reply 0 retweets 1 like
Would be good to talk about the flow that you'd want to use that the tool doesn't yet support. node-core-utils is only a few months old, so lots of room for improvement.
-
-
Replying to @gibfahn @MylesBorins and
well, it’s overkill for what I’m trying to do, but bits of it seem useful. a webhook that invokes the addition of PR-URL or other metadata via `git notes` somehow would be cool.
1 reply 0 retweets 1 like -
Replying to @b0neskull @MylesBorins and
We actually need that as well, for when someone forgets the PR-URL. Commit comments would be a good way to do it.
0 replies 0 retweets 2 likes
End of conversation
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.