And killer feature: version-to-version diffs with smart white-space highlighting: https://linux-review.googlesource.com/c/virt/kvm/kvm/+/1464/4..6/tools/testing/selftests/kvm/demand_paging_test.c … You don't need to manually write up what's changed, and reviewers don't need to trust you blindly. And you see it's only whitespaces, not -whole-line/+whole-line.
-
-
Show this threadThanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
Incredible! How does it relate to the email-based system now? Do actions on either gerrit/email mirrored?
-
@Shiftreduce Well, as of now it's completely optional Annex to the process that is optional and does not affect anything. So you go to gerrit, review there, remember all comments in head then go to mailing list and post there [smiley or sad face on your choice]. - 2 more replies
New conversation -
-
-
is this automatic on new lkml patchsets, or manual and the community needs to adopt it? a better process like this would be so nice.
-
No, everything is manual and up to the patch author. Though, as reviewer you can apply a patch locally and upload to gerrit yourself. I did it for some larger changes that I wanted to _review_ rather than just _stamp_.
End of conversation
New conversation -
-
-
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
-
-
i wonder how it will affect patch cycles.
Thanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.