On Friday I spent the afternoon looking at @trailofbits excellent work on Kubernetes (https://github.com/trailofbits/audit-kubernetes/tree/master/reports …).
As you know, I have been chasing interesting bug classes as part of my daily job, and I found one in the report which I decide to QL (1/n)
-
Show this thread
-
The vulnerability #13 "Overflows when using strconv.Atoi and downcasting the result" basically consist of the method Atoi which returns an int (64 bits on 64b environment)
1 reply 0 retweets 2 likesShow this thread -
Here is one example. In this case, they are actually casting to 32bits to define a port number. Is not really that harmful, but it give you an idea of the problems it could arise.pic.twitter.com/fYCrfsPgGk
1 reply 0 retweets 2 likesShow this thread -
On the Appendix B, you can find a list of 14 places where they found this behaviour. I thought it was a great case for Variant Analysis! Let see if we can find a bit more cases
2 replies 0 retweets 2 likesShow this thread -
I wrote a simple QL query that do Local TainTracking and try to track if the result of Atoi ends up on a wrapper of 32 bits or less! (run it on kubernetes and all their staging proyects)pic.twitter.com/DMgGd2iPEX
1 reply 3 retweets 9 likesShow this thread -
Replying to @nicowaisman @trailofbits
Did you find some that they missed?
1 reply 0 retweets 0 likes -
Replying to @daveaitel @trailofbits
Yep. They were 10 more from the report. https://github.com/kubernetes/kubernetes/issues/81121#issuecomment-520544280 … But I went through all the staging projects.
1 reply 0 retweets 0 likes
Dan Guido Retweeted Bobby T
"missed" is the wrong way to frame it, since we didn't suggest we were comprehensive. It was a demonstration that further research should get conducted.https://twitter.com/b0bbytabl3s/status/1160998111763767300 …
Dan Guido added,
-
-
Replying to @dguido @nicowaisman and
Dan Guido Retweeted Trail of Bits
Our goals for the review were to build a foundation for further research and broadly survey as much attack surface as possible: https://twitter.com/trailofbits/status/1158895151886032897 …. Nico's work is exactly what we hoped would come from it.
Dan Guido added,
Trail of Bits @trailofbitsReplying to @bascule @KirinDaveYes, and we were directed to go for breadth (see discussion in the coverage section). We hope our work provides the foundation for rooting out many high-risk bugs in the future! https://twitter.com/Atlas_Hugged/status/1158774619324633089 … pic.twitter.com/t8uEtPGdFX0 replies 1 retweet 5 likesThanks. Twitter will use this to make your timeline better. UndoUndo
-
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.
