Sometimes I think "that's the ugliest code I've ever seen!". Then I remember about https://github.com/dolphin-emu/dolphin/blob/16060290c2dc3cac5c1cb4643d460bb778cc121d/Source/Core/Core/Src/HW/DSPHLE/UCodes/UCode_AX_ADPCM.h#L66 … and I realize it's not that bad.
-
-
Replying to @delroth_
@delroth_@nlguillemot Plot twist: That's what the HW actually does.1 reply 0 retweets 0 likes -
Replying to @matiasgoldberg
@matiasgoldberg@nlguillemot it's not. That's all implemented in SW, and the proper implementation is a "return vol + delta;".1 reply 0 retweets 0 likes -
Replying to @delroth_
@delroth_@nlguillemot I was just trying to make a joke... **sniff**1 reply 0 retweets 0 likes -
Replying to @matiasgoldberg
@matiasgoldberg@nlguillemot :) There are some terrible things in that DSP software that are actually accurate, but that's not one of these1 reply 0 retweets 1 like -
Replying to @delroth_
@delroth_@matiasgoldberg@nlguillemot I assume there's some reason to not just convert it to return vol + delta; then?1 reply 0 retweets 0 likes -
Replying to @RileyLabrecque
@RileyLabrecque@matiasgoldberg@nlguillemot fixed it already >1 year ago as part of http://blog.lse.epita.fr/articles/38-emulating-the-gamecube-audio-processing-in-dolphin.html …1 reply 0 retweets 1 like
@RileyLabrecque here is the current implementation: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h#L436 … :-)
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.