So to briefly talk about the code review process at Google: there's OWNERS for each piece of code. Anyone who is in the code's OWNERS can submit changes with review from at least one other engineer (not necessarily OWNER). Anyone outside OWNERS has to get approval from an OWNER.
-
-
it's easy enough to do by accident. if the issue is that CLs shouldn't be submitted without g4 mail, then maybe critique shouldn't allow pressing 'submit' without 'mail' first. If it shows LGTM and eligible to submit...
-
In context, would you interpret that as an accident or as an attempt to hide things (maybe realizing your team wouldn't approve of what you're doing)? I agree that accidents happen, but accidents correlated with controversial changes are rare².
- 10 more replies
New conversation -
Loading seems to be taking a while.
Twitter may be over capacity or experiencing a momentary hiccup. Try again or visit Twitter Status for more information.